Skip to content

hypershift: Request higher resoures for unit test jobs #32602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Sep 26, 2022
Merged

hypershift: Request higher resoures for unit test jobs #32602

openshift-merge-robot merged 1 commit into from
Sep 26, 2022

Conversation

@csrwng
Copy link
Contributor

@csrwng csrwng commented Sep 26, 2022

Adding fuzzing tests to API conversion code[1] results in test pods timing out when running unit tests[2]. This PR bumps up the requirements for unit tests so they can actually complete:

[1] openshift/hypershift#1703
[2] https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_hypershift/1703/pull-ci-openshift-hypershift-main-unit/1566800257059131392

Resource requests are based on a successful run of unit tests on a standalone pod:
Screenshot from 2022-09-26 10-41-49

@csrwng csrwng changed the title Request higher resoures for unit test jobs hypershift: Request higher resoures for unit test jobs Sep 26, 2022
@openshift-ci openshift-ci bot requested review from enxebre and sjenning September 26, 2022 08:57
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2022
@enxebre
Copy link
Member

enxebre commented Sep 26, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng, enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 44aee8c into openshift:master Sep 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 26, 2022

@csrwng: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-hypershift-main.yaml using file ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-hypershift-release-4.12.yaml using file ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.12.yaml
Details

In response to this:

Adding fuzzing tests to API conversion code[1] results in test pods timing out when running unit tests[2]. This PR bumps up the requirements for unit tests so they can actually complete:

[1] openshift/hypershift#1703
[2] https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_hypershift/1703/pull-ci-openshift-hypershift-main-unit/1566800257059131392

Resource requests are based on a successful run of unit tests on a standalone pod:
Screenshot from 2022-09-26 10-41-49

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@enxebre enxebre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csrwng @enxebre @openshift-merge-robot